Re: [exim] Exim 4.87 RC7 uploaded

On 01/04/16 22:01, Odhiambo Washington wrote:
> cdb.c: In function 'cdb_find':
> cdb.c:301: warning: passing argument 1 of 'cdb_hash' discards qualifiers
> from pointer target type

How does the attached patch feel?

--
Cheers,
Jeremy
diff --git a/src/src/lookups/cdb.c b/src/src/lookups/cdb.c
index ba925dc..4ff42ab 100644
--- a/src/src/lookups/cdb.c
+++ b/src/src/lookups/cdb.c
@@ -94,7 +94,7 @@ typedef unsigned int uint32;
* Internal function to make hash value */

static uint32
-cdb_hash(uschar *buf, unsigned int len)
+cdb_hash(const uschar *buf, unsigned int len)
{
uint32 h;

@@ -298,7 +298,7 @@ cdb_find(void *handle,
/* Keep picky compilers happy */
do_cache = do_cache;

- key_hash = cdb_hash((uschar *)keystring, key_len);
+ key_hash = cdb_hash(keystring, key_len);

hash_offset_entry = CDB_HASH_ENTRY * (key_hash & CDB_HASH_MASK);
hash_offset = cdb_unpack(cdbp->cdb_offsets + hash_offset_entry);