Re: [pcre-dev] pcre2-10.21-RC1 testing release

Kezdőlap
Üzenet törlése
Szerző: Petr Pisar
Dátum:  
Címzett: pcre-dev
Tárgy: Re: [pcre-dev] pcre2-10.21-RC1 testing release
On Wed, Jan 06, 2016 at 11:15:39AM +0100, Petr Pisar wrote:
> On Fri, Dec 18, 2015 at 10:48:59AM +0000, ph10@??? wrote:
> > I have just put the 10.21-RC1 testing release here:
> >
> While the release works for me on Fedora Linux distribution, it consistently
> fails on Red Hat Enterprise Linux 7 distribution. The only failure is the
> French locale test 3. Maybe the locale definition differ. I don't know the
> exact casue yet.
>
> The test 3 fails on non-jit UTF-8. The testtry output should match
> ./testdata/testoutput3A, but it does not:
>

This is wrong. testdata/testoutput3A is matched on Fedora
(glibc-2.22-7.fc23.x86_64), but on RHEL (glibc-2.17-105.el7.x86_64),
testdata/testoutput3 should be matched. And it isn't because of trailing white
space after an "Expect no match" message.

> The older pcre2-10.20 passes. I bisected the failure to this commit:
>
> commit 4d8cc29bcaed2374f6ccbf1cbfe56c80641c6128
> Author: ph10 <ph10@6239d852-aaf2-0410-a92c-79f79f948069>
> Date: Wed Sep 16 16:49:48 2015 +0000
>
>     Tidied up a lot of comments in the test files.

>
>
>     git-svn-id: svn://vcs.exim.org/pcre2/code/trunk@371 6239d852-aaf2-0410-a92c-79f79f948069

>

This commit added the white space to testdata/testoutput3A, but forgot to add
it to testdata/testoutput3. Therefore the test started to fail.

Attached patch fixes it for me.

-- Petr
From db3b9ca6555fa002eaee742fa650665d16b4eec2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@???>
Date: Wed, 6 Jan 2016 12:42:11 +0100
Subject: [PATCH] Add a trailing space to testdata/testoutput3 for RHEL-7
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Frech locale test 3 is expected to match testdata/testoutput3 on
RHEL-7 glibc. But it's missing a trailing space that was added into
testdata/testoutput3A only.

Signed-off-by: Petr Písař <ppisar@???>
---
testdata/testoutput3 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testdata/testoutput3 b/testdata/testoutput3
index d9e8c5c..77e3d75 100644
--- a/testdata/testoutput3
+++ b/testdata/testoutput3
@@ -104,7 +104,7 @@ Subject length lower bound = 1
 /^[\xc8-\xc9]/
     ?cole
  0: ?
-\= Expect no match
+\= Expect no match 
     ?cole
 No match


--
2.5.0