[exim-dev] Clang warnings for RC2 #4

Top Page
Delete this message
Reply to this message
Author: Richard Clayton
Date:  
To: exim-dev
Subject: [exim-dev] Clang warnings for RC2 #4

More dangling else's ... easily fixed with extra {} for the outer if
statement ... though the instance in exim.c could be tidied up a bit
more than that for clarity.

acl.c:1838:7: warning: add explicit braces to avoid dangling else
[-Wdangling-else]
      else
      ^
dns.c:997:7: warning: add explicit braces to avoid dangling else
[-Wdangling-else]
      else if (namesuff - 4 > name && strcmpic(namesuff - 4,
US".ip6.arpa") == 0)
      ^
exim.c:3434:46: warning: add explicit braces to avoid dangling else
[-Wdangling-else]
      if (++i < argc) log_oneline = argv[i]; else
                                             ^
exim.c:5412:11: warning: add explicit braces to avoid dangling else
[-Wdangling-else]
          else
          ^
expand.c:6707:3: warning: add explicit braces to avoid dangling else
[-Wdangling-else]
                else
                ^
parse.c:556:5: warning: add explicit braces to avoid dangling else
[-Wdangling-else]
    else
    ^
smtp_in.c:3021:5: warning: add explicit braces to avoid dangling else
[-Wdangling-else]
    else
    ^
-- 
richard                                                   Richard Clayton


Those who would give up essential Liberty, to purchase a little temporary
Safety, deserve neither Liberty nor Safety. Benjamin Franklin 11 Nov 1755