[pcre-dev] [Bug 1674] New: CMakeLists: Improper override of …

https://bugs.exim.org/show_bug.cgi?id=1674

            Bug ID: 1674
           Summary: CMakeLists: Improper override of CMAKE_C_FLAGS
           Product: PCRE
           Version: 10.20 (PCRE2)
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: bug
          Priority: medium
         Component: Code
          Assignee: ph10@???
          Reporter: Roy.Ivy.III@???
                CC: pcre-dev@???

CMakeLists.txt includes:

```
SET(CMAKE_C_FLAGS -I${PROJECT_SOURCE_DIR}/src)
```

which overrides any custom CMAKE_C_FLAGS.

It should include any prior setting by instead using:

```
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -I${PROJECT_SOURCE_DIR}/src")
```

This is necessary for customization such as increasing the stack size during
compilation (using `cmake -D CMAKE_C_FLAGS=-Wl,--stack,8000000 ...`).

Thanks for investigating.

ref:
https://github.com/rivy/PCRE2-mirror/commit/bbeff8fecfe8512d2863cfa7b8b2d4e16359c36d

- Roy

--
You are receiving this mail because:
You are on the CC list for the bug.