Jeremy Harris <jgh@???> wrote:
>
> This arrived too late for 4.86; sorry.
:-(
> We now have the option of an incompatible change or a bit
> of massaging - something like, requesting +incoming_interface
> sets the default display of interface for both
> incoming and outgoing, but this is overridden by a
> request of -outgoing_interface.
Perhaps it makes sense to turn on outgoing_interface if both
incoming_interface and outgoing_port are set.
Using -outgoing_interface as an override makes sense.
> - Debug output should not include the word "fanf"
Oops, I thought I had removed those :-)
> - The value of logging the outgoing ephemeral port is dubious
It's often useful for correlating connections and NAT logs. Perhaps this
should be conditional on outgoing_port.
> - The arg count for decode_bits() is getting silly, with the
> addition of the third log_selector word. Maybe it is
> time to move to an array of words and lose the top-bit(s)
> hack
Probably...
Tony.
--
f.anthony.n.finch <dot@???>
http://dotat.at/
Thames, Dover: Southwest 6 to gale 8, perhaps severe gale 9 later. Moderate or
rough, becoming rough or very rough. Showers. Good.
