Re: [exim-dev] [PATCH] log_selector +outgoing_interface

Top Page
Delete this message
Reply to this message
Author: Jeremy Harris
Date:  
To: Tony Finch, exim-dev
Subject: Re: [exim-dev] [PATCH] log_selector +outgoing_interface
On 21/07/15 11:56, Tony Finch wrote:
> +TF/01 Add a separate outgoing_interface log selector, and move the interface
> +      field after the remote host for consistency with incoming_interface.


This arrived too late for 4.86; sorry.

We now have the option of an incompatible change or a bit
of massaging - something like, requesting +incoming_interface
sets the default display of interface for both
incoming and outgoing, but this is overridden by a
request of -outgoing_interface.

Thoughts on this?


General points:

- Debug output should not include the word "fanf"
- The value of logging the outgoing ephemeral port is dubious
- The arg count for decode_bits() is getting silly, with the
addition of the third log_selector word. Maybe it is
time to move to an array of words and lose the top-bit(s)
hack

--
Cheers,
Jeremy