Re: [pcre-dev] Dependency issue

Page principale
Supprimer ce message
Auteur: ph10
Date:  
À: Ze'ev Atlas
CC: pcre-dev
Sujet: Re: [pcre-dev] Dependency issue
On Thu, 16 Jul 2015, Ze'ev Atlas wrote:

> Hi PhilipI gave it a lot of thought and I would like to plead with
> you, before I go to a non-standard solution and before you continue
> with potentially dangerous structure.  Shouldn't it be better to
> put find_bracket (and potentially other such routines) into a module
> unto themselves, perhaps pcre2_supportfunctions.c and in that way open
> them to use from any module without circular dependency issue? Ze'ev
> Atlas


OK, I agree it would be cleaner. In fact, find_bracket is the only such
function, so it could have a module to itself.

This same issue exists in PCRE1 (which I will not be changing). I wonder
why you did not notice it then? Ah! Of course! pcre_study() is not
automatically called from pcre_compile() in PCRE1. It's that change that
has created this problem.

Philip

--
Philip Hazel