Re: [pcre-dev] issues with EBCDIC and pcretest

Top Pagina
Delete this message
Auteur: Ze'ev Atlas
Datum:  
Aan: pcre-dev@exim.org, Philip Hazel
Onderwerp: Re: [pcre-dev] issues with EBCDIC and pcretest
Reviewed the code just one more time.There should be:
if (ebcdic_valid != 0) {    *errorcodeptr = ERR68;
    break;}
instead of if (ebcdic_valid != 0) *errorcodeptr = ERR68;
 Ze'ev Atlas


      From: Ze'ev Atlas <zatlas1@???>
 To: "pcre-dev@???" <pcre-dev@???>; Philip Hazel <ph10@???> 
 Sent: Friday, June 12, 2015 9:37 AM
 Subject: Re: [pcre-dev] issues with EBCDIC and pcretest


Hi PhilipHere is my patch.  One version without my comments and one with... your choice.The patch allows for keeping the old, flawed code, but you can modify to just replace that code if you wish Ze'ev Atlas




     From: "ph10@???" <ph10@???>
 To: Ze'ev Atlas <zatlas1@???> 
Cc: pcre exim <pcre-dev@???> 
 Sent: Friday, June 12, 2015 3:36 AM
 Subject: Re: [pcre-dev] issues with EBCDIC and pcretest


On Fri, 12 Jun 2015, Ze'ev Atlas wrote:

> I wrote and tested the patch.  I will send it next week.  ]c works
> like what is defined in Perlebcdic Ze'ev Atlas


That saves me having to tell you where to look. :-)

I've had more thoughts about this. I guess if it brings PCRE more into
line with Perl it is perhaps something worth doing, so I will consider
your patch when you send it.



Philip

--
Philip Hazel