[exim-dev] [Bug 1609] Unescaped user input dumped to logfile

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1609

Git Commit <git@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git@???

--- Comment #1 from Git Commit <git@???> 2015-04-06 19:17:06 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/0ebc4d69b3211e47f0df60ebc43e1735d91286f8

commit 0ebc4d69b3211e47f0df60ebc43e1735d91286f8
Author:     Simon Amor <simon@???>
AuthorDate: Mon Apr 6 18:12:54 2015 +0100
Commit:     Jeremy Harris <jgh146exb@???>
CommitDate: Mon Apr 6 18:15:15 2015 +0100

    Care with printability of logged information.  Bug 1609
---
 src/src/smtp_in.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/src/smtp_in.c b/src/src/smtp_in.c
index 58ca02d..9b7c59d 100644
--- a/src/src/smtp_in.c
+++ b/src/src/smtp_in.c
@@ -2438,7 +2438,7 @@ if (++synprot_error_count > smtp_max_synprot_errors)
   yield = 1;
   log_write(0, LOG_MAIN|LOG_REJECT, "SMTP call from %s dropped: too many "
     "syntax or protocol errors (last command was \"%s\")",
-    host_and_ident(FALSE), smtp_cmd_buffer);
+    host_and_ident(FALSE), string_printing(smtp_cmd_buffer));
   }

 if (code > 0)
@@ -3397,7 +3397,7 @@ while (done <= 0)
         {
         log_write(0, LOG_MAIN|LOG_REJECT, "SMTP call from %s dropped: too many
"
           "syntax or protocol errors (last command was \"%s\")",
-          host_and_ident(FALSE), smtp_cmd_buffer);
+          host_and_ident(FALSE), string_printing(smtp_cmd_buffer));
         done = 1;
         }

@@ -5015,7 +5015,7 @@ while (done <= 0)
       done = 2;
       log_write(0, LOG_MAIN|LOG_REJECT, "SMTP call from %s dropped: too many "
         "unrecognized commands (last was \"%s\")", host_and_ident(FALSE),
-        smtp_cmd_buffer);
+        string_printing(smtp_cmd_buffer));
       }
     else
       done = synprot_error(L_smtp_syntax_error, 500, NULL,

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email