[exim-dev] [Bug 1552] lack of correct truncated string lengt…

Top Page
Delete this message
Reply to this message
Author: Git Commit
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 1552] lack of correct truncated string length storage in spam address
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1552

Git Commit <git@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git@???





--- Comment #1 from Git Commit <git@???> 2014-11-27 17:17:05 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/e252eb8c71ea3bddb32bf73bddc8b22cfde2bc3a

commit e252eb8c71ea3bddb32bf73bddc8b22cfde2bc3a
Author:     Jeremy Harris <jgh146exb@???>
AuthorDate: Thu Nov 27 16:26:44 2014 +0000
Commit:     Jeremy Harris <jgh146exb@???>
CommitDate: Thu Nov 27 16:30:14 2014 +0000


    Fix buffer overrun in spam= acl condition.  Bug 1552
---
 src/src/spam.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


diff --git a/src/src/spam.c b/src/src/spam.c
index 7eb6fbf..76bf7d6 100644
--- a/src/src/spam.c
+++ b/src/src/spam.c
@@ -129,7 +129,8 @@ spam(uschar **listptr)
         (spamd_address_container *)store_get(sizeof(spamd_address_container));


       /* grok spamd address and port */
-      if( sscanf(CS address, "%s %u", this_spamd->tcp_addr,
&(this_spamd->tcp_port)) != 2 ) {
+      if (sscanf(CS address, "%23s %u", this_spamd->tcp_addr,
&(this_spamd->tcp_port)) != 2)
+        {
         log_write(0, LOG_MAIN,
           "spam acl condition: warning - invalid spamd address: '%s'",
address);
         continue;



--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email