[exim-dev] [Bug 1533] headers_remove items size-limited

Top Page
Delete this message
Reply to this message
Author: Git Commit
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 1533] headers_remove items size-limited
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1533

Git Commit <git@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git@???





--- Comment #1 from Git Commit <git@???> 2014-10-05 22:17:07 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/8bc732e8b03ebb4309f4b42626917148d176db49

commit 8bc732e8b03ebb4309f4b42626917148d176db49
Author:     Jeremy Harris <jgh146exb@???>
AuthorDate: Sun Oct 5 21:31:20 2014 +0100
Commit:     Jeremy Harris <jgh146exb@???>
CommitDate: Sun Oct 5 21:40:50 2014 +0100


    Remove limit on remove_headers item size. Bug 1533
---
 doc/doc-txt/ChangeLog |    5 +++++
 src/src/transport.c   |    3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)


diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index 76ecc20..0b03894 100644
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -44,6 +44,11 @@ JH/05 Fix results-pipe from transport process.  Several
recipients, combined
       to notice due to the introduction of conection certificate information,
       the item size being so much larger.  Found and fixed by Wolfgang Breyha.


+JH/06 Bug 1533: Fix truncation of items in headers_remove lists.  A fixed
+      size buffer was used, resulting in syntax errors when an expansion
+      exceeded it.
+
+
 Exim version 4.84
 -----------------
 TL/01 Bugzilla 1506: Re-add a 'return NULL' to silence complaints from static
diff --git a/src/src/transport.c b/src/src/transport.c
index 31437b1..15c30bf 100644
--- a/src/src/transport.c
+++ b/src/src/transport.c
@@ -643,8 +643,7 @@ for (h = header_list; h != NULL; h = h->next) if (h->type
!= htype_old)
       {
       int sep = ':';         /* This is specified as a colon-separated list */
       uschar *s, *ss;
-      uschar buffer[128];
-      while ((s = string_nextinlist(&list, &sep, buffer, sizeof(buffer))))
+      while ((s = string_nextinlist(&list, &sep, NULL, 0)))
        {
        int len;




--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email