Re: [exim-dev] [Bug 1489] ${certextract} parse error (4.83 R…

Góra strony
Delete this message
Reply to this message
Autor: Viktor Dukhovni
Data:  
Dla: exim-dev
Temat: Re: [exim-dev] [Bug 1489] ${certextract} parse error (4.83 RC1)
On Thu, Jun 05, 2014 at 04:17:08PM +0100, Git Commit wrote:

> http://git.exim.org/exim.git/commitdiff/315e209ab63a4d198d4592247cabf52b9401844d
> Author:     Jeremy Harris <jgh146exb@???>
> AuthorDate: Thu Jun 5 15:16:29 2014 +0100
> Commit:     Jeremy Harris <jgh146exb@???>
> CommitDate: Thu Jun 5 15:16:29 2014 +0100


I think this code is too ad-hoc to pass review. It assumes particular
formatting of output for human consumption. The original code that
attempted to map the signature algorithm OID to its name was better,
and should be repaired not replaced with a mess.

-- 
    Viktor.