[exim-dev] [Bug 1408] smtp_confirmation logging truncated (m…

Top Page
Delete this message
Reply to this message
Author: Git Commit
Date:  
To: exim-dev
Old-Topics: [exim-dev] [Bug 1408] New: smtp_confirmation logging truncated (max. 100 chars)
Subject: [exim-dev] [Bug 1408] smtp_confirmation logging truncated (max. 100 chars)
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1408

Git Commit <git@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git@???





--- Comment #3 from Git Commit <git@???> 2014-05-26 17:17:07 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/27520a688253e1f73c6f59b32312cdf2755aed2c

commit 27520a688253e1f73c6f59b32312cdf2755aed2c
Author:     Jeremy Harris <jgh146exb@???>
AuthorDate: Mon May 26 16:26:58 2014 +0100
Commit:     Jeremy Harris <jgh146exb@???>
CommitDate: Mon May 26 16:26:58 2014 +0100


    Increase limit of smtp_confirmation logging from 100 to 256 chars.  Bug
1408
---
 src/src/deliver.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)


diff --git a/src/src/deliver.c b/src/src/deliver.c
index 70f6a7a..3f5800d 100644
--- a/src/src/deliver.c
+++ b/src/src/deliver.c
@@ -842,17 +842,17 @@ else

/* confirmation message (SMTP (host_used) and LMTP (driver_name)) */

-if ((log_extra_selector & LX_smtp_confirmation) != 0 &&
-    addr->message != NULL &&
-    ((addr->host_used != NULL) || (Ustrcmp(addr->transport->driver_name,
"lmtp") == 0)))
+if (log_extra_selector & LX_smtp_confirmation &&
+    addr->message &&
+    (addr->host_used || Ustrcmp(addr->transport->driver_name, "lmtp") == 0))
   {
   int i;
   uschar *p = big_buffer;
   uschar *ss = addr->message;
   *p++ = '\"';
-  for (i = 0; i < 100 && ss[i] != 0; i++)
+  for (i = 0; i < 256 && ss[i] != 0; i++)      /* limit logged amount */
     {
-    if (ss[i] == '\"' || ss[i] == '\\') *p++ = '\\';
+    if (ss[i] == '\"' || ss[i] == '\\') *p++ = '\\'; /* quote \ and " */
     *p++ = ss[i];
     }
   *p++ = '\"';



--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email