[exim-dev] error message patch

Αρχική Σελίδα
Delete this message
Reply to this message
Συντάκτης: Osborne, Paul (paul.osborne@canterbury.ac.uk)
Ημερομηνία:  
Προς: exim-dev@exim.org
Αντικείμενο: [exim-dev] error message patch
Hi,


Having spent a chunk of this afternoon debugging an Exim configuration I mailed out to the users list on the off chance where someone else had the decency to grep the source code whilst I was eating dinner...

In any case having just looked at the source and apologies for not knowing the patch submission procedure, I would like to submit the following - this applies to the 4.80.1 tree which I think is current:


=========PATCH START==========

--- readconf.c    2012-10-25 04:37:38.000000000 +0100
+++ readconf.c.2    2013-05-23 21:52:17.000000000 +0100
@@ -3783,7 +3783,7 @@
   pp = p;
   while (mac_isgraph(*p)) p++;
   if (p - pp <= 0) log_write(0, LOG_PANIC_DIE|LOG_CONFIG_IN,
-    "missing error type");
+    "missing error type in Retry rules");


/* Test error names for things we understand. */
===========PATCH END============


This specifically applies to the config parser and makes the initial Retry rules error message at least indicate which section of the config that the error applies to - which to my mind is much more helpful than the previous message.


Please use or lose the patch at your discretion.


Many thanks


Paul
--
Paul Osborne
Systems Analyst
Infrastructure Group
Computing Services
Canterbury Christ Church University