[Pcre-svn] [1236] code/trunk: A minor change from uchar to u…

Startseite
Nachricht löschen
Autor: Subversion repository
Datum:  
To: pcre-svn
Betreff: [Pcre-svn] [1236] code/trunk: A minor change from uchar to unsigned int improves performance in some
Revision: 1236
          http://vcs.pcre.org/viewvc?view=rev&revision=1236
Author:   ph10
Date:     2012-12-30 17:09:59 +0000 (Sun, 30 Dec 2012)


Log Message:
-----------
A minor change from uchar to unsigned int improves performance in some
environments. Also correct a missing "unsigned".

Modified Paths:
--------------
    code/trunk/ChangeLog
    code/trunk/pcre_exec.c


Modified: code/trunk/ChangeLog
===================================================================
--- code/trunk/ChangeLog    2012-12-10 13:36:29 UTC (rev 1235)
+++ code/trunk/ChangeLog    2012-12-30 17:09:59 UTC (rev 1236)
@@ -15,6 +15,12 @@
 3.  Revise the creation of config.h.generic so that all boolean macros are
     #undefined, whereas non-boolean macros are #ifndef/#endif-ed. This makes
     overriding via -D on the command line possible.  
+    
+4.  Changing the definition of the variable "op" in pcre_exec.c from pcre_uchar
+    to unsigned int is reported to make a quite noticeable speed difference in
+    a specific Windows environment. Testing on Linux did also appear to show
+    some benefit (and it is clearly not harmful). Also fixed the definition of
+    Xop which should be unsigned. 



Version 8.32 30-November-2012

Modified: code/trunk/pcre_exec.c
===================================================================
--- code/trunk/pcre_exec.c    2012-12-10 13:36:29 UTC (rev 1235)
+++ code/trunk/pcre_exec.c    2012-12-30 17:09:59 UTC (rev 1236)
@@ -416,9 +416,9 @@
   int Xlength;
   int Xmax;
   int Xmin;
-  int Xnumber;
+  unsigned int Xnumber;
   int Xoffset;
-  int Xop;
+  unsigned int Xop;
   int Xsave_capture_last;
   int Xsave_offset1, Xsave_offset2, Xsave_offset3;
   int Xstacksave[REC_STACK_SAVE_MAX];
@@ -634,7 +634,7 @@
 int min;
 unsigned int number;
 int offset;
-pcre_uchar op;
+unsigned int op;
 int save_capture_last;
 int save_offset1, save_offset2, save_offset3;
 int stacksave[REC_STACK_SAVE_MAX];