Re: [pcre-dev] [PATCH] Miscellaneous fixes from Solaris 2.6

トップ ページ
このメッセージを削除
著者: Christian Persch
日付:  
To: pcre-dev
CC: danielg
題目: Re: [pcre-dev] [PATCH] Miscellaneous fixes from Solaris 2.6
Hi;

Am Mon, 22 Oct 2012 17:38:39 -0400
schrieb Daniel Richard G. <oss@???>:
> I recently attempted to build PCRE SVN trunk on Solaris 2.6 (on
> 32-bit SPARC) to try out Zoltán's new JIT support for that platform.
> While that is still in progress, there are a few minor issues that
> came up in building PCRE on this older system, that are addressed in
> the attached patch. These are as follows:
>
> pcre_internal.h: Header macros need to be checked as e.g.
>
>      #if defined HAVE_STDINT_H

>
> rather than
>
>      #if HAVE_STDINT_H

>
> or else -Wundef gives you "HAVE_STDINT_H is not defined" warnings.


Fixed in SVN now.

> Makefile.am: The "?=" assignment is a GNU Make extension, not
> compatible with classic Unix make(1) programs. (Indeed, make(1) gave
> a confusing error on this system until I removed those assignments.)
>
> The "coverage-clean" target is invoked by "make clean". The former
> does not check that LCOV is set to a value before invoking it.
>
> Also, older versions of find(1) do not support the -delete predicate.


I wrapped the coverage report generating rules in an automake ifdef now.
Configure ensures that lcov is found, so that part shouldn't be a
problem. I don't like the change to the find invocation, since -delete
is more secure than -exec. Not sure how high we should value
portability of these gcov rules; after all they're intended to be only
used by the pcre developers themselves.

Regards,
    Christian