[pcre-dev] [Bug 1295] add 32-bit library

Góra strony
Delete this message
Autor: Philip Hazel
Data:  
Dla: pcre-dev
Temat: [pcre-dev] [Bug 1295] add 32-bit library
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1295




--- Comment #16 from Philip Hazel <ph10@???> 2012-10-17 16:33:44 ---
On Tue, 16 Oct 2012, Christian Persch wrote:

> I've tested this extensively, using different configure options and compile
> flags (-O0, -O2), on x86. It's quite possible there are problems either in new
> code, or regressions, on other architectures; so it would be great if everyone
> could test this! :-)


This is excellent work! Thank you for all the effort. I have found some
issues, which I am happy to work on myself. They are all trivialities.

1. It fails to build if you select only 8 and 16 bit libraries: the
variables cn32ptr and gn32ptr are not defined but are used in pcretest.

2. When selecting all 3 libraries it builds and runs the tests, but
there are a number of compiler warnings, typically

  . Signed/unsigned comparisons. I know the source is a complete mess in 
    this regard (all my fault for not getting it right at the start) but 
    a few casts should fix it.


  . C++ style comments: I have avoided using these just in case somebody 
    with a non-C++ compiler wants to compile it. (I have no idea, for 
    example, if the z/OS compiler recognizes C++ comments.)


  . When not compiling 32-bit, there were a number of warnings like 
    this:


    pcretest.c:1953:3: warning: implicit declaration of function 'PCHARSV32'
    pcretest.c:1953:3: warning: nested extern declaration of 'PCHARSV32'


> Things remaining to do:
> * update RunTest.bat. It appears this wasn't updated in a while (missing tests
> 21 and 22 already), and I'm not confident in writing this language, so I left
> it be.


I am not confident about that either. Hopefully one of our Windows users
will help when we make a Release Candidate.

> * test CMake builds


I will test this once I have got rid of all the compiler warnings.

> * make JIT support the masking of high bits in UTF mode


That's Zoltán's problem. :-)

Philip


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email