Hi,
the patch works for me so I landed it.
Thanks,
Zoltan
"Zoltán Herczeg" <hzmester@???> írta:
>I have cmake + windows box, so I will check this patch in due course.>
>
Regards,>
Zoltan>
>
"Daniel Richard G." <oss@???> írta:>
>I was building PCRE on Windows, but the pcre_test_bat test was not working >>
for me. There were a few issues with how RunTest.bat is invoked via CMake, >>
and how the batch file makes use of quoting; the attached patch addresses >>
these:>>
>>
++ CMakeLists.txt>>
>>
* Added quoting to "When testing is complete..." message for better>>
clarity when PROJECT_BINARY_DIR contains spaces>>
>>
* MESSAGE("") does not print a blank line, but MESSAGE(" ") does>>
>>
* Reworked the generation of pcre_test.txt (now pcre_test.bat) to handle>>
path quoting correctly (Windows convention is to use quoting only with>>
literal path values, not with variable dereferences), and use>>
%CMAKE_CONFIG_TYPE% to play well with IDEs that build different>>
configurations of pcretest.exe>>
>>
* Got rid of BatDriver.cmake, as the extra indirection should no longer be>>
needed>>
>>
++ RunTest.bat>>
>>
* Fixed quoting>>
>>
>>
I proofed this using Visual Studio IDE and NMake-makefile CMake >>
generators, with spaces in both the source and binary directory paths.>>
>>
>>
--Daniel>>
>>
>>
-- >>
Daniel Richard G. || danielg@??? || Software Developer>>
Teragram Linguistic Technologies (a division of SAS)>>
http://www.teragram.com/-- >>
## List details at
https://lists.exim.org/mailman/listinfo/pcre-dev >
>
-- >
## List details at
https://lists.exim.org/mailman/listinfo/pcre-dev
