Re: [exim] Exim 4.80 RC5 uploaded

On 24 May 2012 10:48, Dennis Davis <D.H.Davis@???> wrote:
> On Thu, 24 May 2012, A J Thew wrote:
>
>> From: A J Thew <aj.thew@???>
>> To: exim-users@???
>> Date: Thu, 24 May 2012 09:59:27
>> Subject: Re: [exim] Exim 4.80 RC5 uploaded
>
> ...
>
>> Hi has anyone tried with an old gcc (2.95)? On Solaris 2.9/gcc 2.95.2
>>
>> I get:
>>
>> gcc pdkim.c
>> pdkim.c: In function `pdkim_feed_finish':
>> pdkim.c:1389: parse error before `*'
>> pdkim.c:1390: `hdrs' undeclared (first use in this function)
>> pdkim.c:1390: (Each undeclared identifier is reported only once
>> pdkim.c:1390: for each function it appears in.)
>> gmake[2]: *** [pdkim.o] Error 1
>
> Just tried this.  Seen this before with gcc 2.95.2.  It *really*
> likes to have the declarations before any of the executable
> statements.  So apply this simple patch:
>
> *** pdkim.c.orig        Thu May 24 04:43:20 2012
> --- pdkim.c     Thu May 24 10:41:22 2012
> ***************
> *** 1383,1392 ****
>        char *b = strdup(sig->headernames);
>        char *p = b;
>        char *q = NULL;
>        if (b == NULL) return PDKIM_ERR_OOM;
>
>        /* clear tags */
> -       pdkim_stringlist *hdrs = ctx->headers;
>        while (hdrs != NULL) {
>          hdrs->tag = 0;
>          hdrs = hdrs->next;
> --- 1383,1392 ----
>        char *b = strdup(sig->headernames);
>        char *p = b;
>        char *q = NULL;
> +       pdkim_stringlist *hdrs = ctx->headers;
>        if (b == NULL) return PDKIM_ERR_OOM;
>
>        /* clear tags */
>        while (hdrs != NULL) {
>          hdrs->tag = 0;
>          hdrs = hdrs->next;

Great. Many thanks

--
Alan Thew