[exim-dev] [Bug 1184] code refactoring in acl.c

Top Page
Delete this message
Reply to this message
Author: Jeremy Harris
Date:  
To: exim-dev
Old-Topics: [exim-dev] [Bug 1184] New: code refactoring in acl.c
Subject: [exim-dev] [Bug 1184] code refactoring in acl.c
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1184

Jeremy Harris <jgh146exb@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #554 is|0                           |1
           obsolete|                            |





--- Comment #3 from Jeremy Harris <jgh146exb@???> 2012-04-04 01:28:10 ---
Created an attachment (id=555)
--> (http://bugs.exim.org/attachment.cgi?id=555)
Code refactoring for verify= parse in acl (updated x2)

Essentially the same coding error in another place, affecting the callout=
parsing. Plus a really stupid thinko.

Fixing those tidies up most of the testsuite cases. Of particular interest in
the outstanding ones, though, is:

Basic/0376 callout verification (with caching)
===============f test-stdout-munged with stdout/0376 failed
Line 370 of "test-stdout-munged" does not match line 370 of "stdout/0376".
----------
MAIL FROM:<pmsend@???>
----------
MAIL FROM:<>
===============
Line 436 of "test-stdout-munged" does not match line 436 of "stdout/0376".
----------
MAIL FROM:<pmsend@???>
----------
MAIL FROM:<>
===============
2 differences found.
"test-stdout-munged" contains 442 lines; "stdout/0376" contains 442 lines.

Continue, Update & retry, Quit? [Q] c
Script completed

for which, if I read correctly, the testcase is doing a
postmaster_mailfrom= callout but the results are set up for a blank from.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email