Re: [exim-dev] [Bug 1184] code refactoring in acl.c

Top Page

Reply to this message
Author: Phil Pennock
Date:  
To: Todd Lyons
CC: exim-dev
Subject: Re: [exim-dev] [Bug 1184] code refactoring in acl.c
On 2012-03-30 at 14:10 -0700, Todd Lyons wrote:
> Are there more places with underscores that need to be touched? It
> still fails on what looks like what should be something replaced:


($parm_caller,$pwpw,$parm_caller_uid,$parm_caller_gid,$pwquota,$pwcomm,
$parm_caller_gecos, $parm_caller_home) = getpwuid($>);
# ...
print "Program caller is $parm_caller, whose group is $parm_caller_group\n";
print "Home directory is $parm_caller_home\n";
# ...
s/\Q$parm_caller_home\E/CALLER_HOME/g; # NOTE: these must be done

You probably need, for user "foo" running the tests, to have the tests
checked out and run somewhere under "foo"'s home directory. Since the
testing also needs to be mounted in an area which needs setuid, you may
need the home directory to be somewhere not in the usual place. I have
/usr/globnix/homes/exim-build/ for this, so that /home can remain
protected.

When I first ran the tests, I found a whole bunch of undocumented
assumptions and updated test/README with anything I found. I encourage
folks to continue along this path.

-Phil