Re: [pcre-dev] Fix for newline error

Top Page
Delete this message
Author: Sheri
Date:  
To: Herczeg Zoltán
CC: pcre-dev@exim.org
Subject: Re: [pcre-dev] Fix for newline error
Hi Zoltan :)

There seems to be another problem in the CMake processing.

The target for building pcre_jit_test only gets set if both jit and utf8
support are elected. As it turns out, if ucp support is elected and utf8
support is not, utf8 support gets forced. But the variable that gets set
is not the same one that causes pcre_jit_test to be set up.

I think that could be easily fixed in the CMakeLists.txt file, but
should the building of the pcre_jit_test program be excluded in the
absense of utf8 support?

Still working on testing the patch (and also on an update for RunTest.bat)

Regards,
Sheri


On 9/16/2011 2:02 PM, Herczeg Zoltán wrote:
> Hi Sheri,
>
> Is this ok:
>
> Index: pcre_jit_test.c
> ===================================================================
> --- pcre_jit_test.c     (revision 694)
> +++ pcre_jit_test.c     (working copy)
> @@ -40,9 +40,12 @@
>   -----------------------------------------------------------------------------
>   */

>
> +#ifdef HAVE_CONFIG_H
> +#include "config.h"
> +#endif
> +
> #include<stdio.h>
> #include<string.h>
> -#include<time.h>
> #include "pcre.h"
>
> #define PCRE_BUG 0x80000000
>
> By the way, my name is in Hungarian naming order, thus Zoltan is my first name and prefer to use that :)
>
> Regards,
> Zoltan
>