On 2011-06-10 at 19:46 +1000, Ted Cooper wrote:
> On 10/06/11 19:01, Phil Pennock wrote:
> > On 2011-06-08 at 11:24 -0700, Todd Lyons wrote:
> >> fake_response_text is a pointer defined in globals.c, but it can be
> >> overridden by you, the admin in your ACLs. In acl.c, we have:
> >>
> >> fake_response_text = expand_string(string_copyn(p+1, pp-p-1));
> >
> > Candidate fix for this not handling expand_string() failing and
> > returning NULL:
>
> Looks good as it ensures that there will always be a message there. It
> seems to have been copied from somewhere though as the messages are wrong ;)
>
> "expanding ratelimit string failed"
> "failed to expand ACL ratelimit"
Ah, that's why the phrase "ratelimit" snuck into my brain for one of the
replies; I just moved the error message in the code and didn't pay too
much attention to the actual phrasing, once I'd noticed that it was
multiline.
> (After installing the ShowIP Add-on to Firefox, woohoo! The Exim website
> is all IPv6 enabled!)
ShowIP shows the IPs from DNS resolution, not the IPs actually used for
the connection. :(
