Re: [exim-dev] [exim] Numerous segfaults with 64 bit exim

Page principale
Supprimer ce message
Répondre à ce message
Auteur: Ted Cooper
Date:  
À: exim-dev
Sujet: Re: [exim-dev] [exim] Numerous segfaults with 64 bit exim
On 10/06/11 19:01, Phil Pennock wrote:
> On 2011-06-08 at 11:24 -0700, Todd Lyons wrote:
>> fake_response_text is a pointer defined in globals.c, but it can be
>> overridden by you, the admin in your ACLs. In acl.c, we have:
>>
>>         fake_response_text = expand_string(string_copyn(p+1, pp-p-1));

>
> Candidate fix for this not handling expand_string() failing and
> returning NULL:


Looks good as it ensures that there will always be a message there. It
seems to have been copied from somewhere though as the messages are wrong ;)

"expanding ratelimit string failed"
"failed to expand ACL ratelimit"


It would be interesting to know what causes the string to fail and
return NULL in this instance though. I haven't been able to trigger it
in my limited testing.

Ted.

(After installing the ShowIP Add-on to Firefox, woohoo! The Exim website
is all IPv6 enabled!)