[exim-dev] [Bug 1086] wrong return value in maildir_ensure_s…

Top Pagina
Delete this message
Reply to this message
Auteur: Phil Pennock
Datum:  
Aan: exim-dev
Onderwerp: [exim-dev] [Bug 1086] wrong return value in maildir_ensure_sizefile
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1086

Phil Pennock <pdp@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pdp@???
         AssignedTo|nigel@???              |pdp@???





--- Comment #1 from Phil Pennock <pdp@???> 2011-02-21 05:42:51 ---
I've fixed the return value, left the errno stuff alone, and done something to
act slightly better on the changed return value.

The appendfile code is written on the basis that after
maildir_ensure_sizefile() returns != -1, the size and filecount are available.
The most appropriate solution, other than deferral for this too, seems to be to
disable quota checks in the event of a race, since the size & count won't have
been set.

Another approach would be to also set the size and filecount for the -2 case,
just nuke the file. I have no strong opinion either way.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email