[exim-dev] [Bug 1086] New: wrong return value in maildir_ens…

Top Page
Delete this message
Reply to this message
Author: Heiko Schlittermann
Date:  
To: exim-dev
New-Topics: [exim-dev] [Bug 1086] wrong return value in maildir_ensure_sizefile
Subject: [exim-dev] [Bug 1086] New: wrong return value in maildir_ensure_sizefile
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1086
           Summary: wrong return value in maildir_ensure_sizefile
           Product: Exim
           Version: 4.74
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: bug
          Priority: low
         Component: Transports
        AssignedTo: nigel@???
        ReportedBy: hs+exim@???
                CC: exim-dev@???



Created an attachment (id=461)
--> (http://bugs.exim.org/attachment.cgi?id=461)
fix for the above problem

Hello,

according to the comment in tf_maildir.c and according to the usage of
the maildir_ensure_sizefile() function, the return value in face of a race
condition should be -2, not -1.

Probably this only bites on a flooded system where the maildirsize file
gets removed quite often. The wrong return value causes deferred delivery.


Additionally I changed a variable definition in appendfile.c
to a more local place. (It's not important, but looks nicer to me :)

--
Heiko


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email