[exim-dev] [Bug 1007] tod_stamp uses non-reentrant localtime…

Top Page
Delete this message
Reply to this message
Author: Christof Meerwald
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 1007] tod_stamp uses non-reentrant localtime()
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1007




--- Comment #4 from Christof Meerwald <cmeerw@???> 2010-07-11 10:32:01 ---
I guess the main problem with the patch is that it doesn't fix anything at all.

localtime_r/gmtime_r are no more or less async-signal-safe than
localtime/gmtime (as a quick look at the link I had posted would have confirmed
- or alternatively, a look at the glibc source code).

But as I also mentioned, there are more problems with the signal handler code,
like using the global log_buffer or closing the log files in the signal
handler.

Being a bit less arrogant would perhaps have helped you here...


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email