Re: [exim] ClamAV changes needing testing

Góra strony
Delete this message
Reply to this message
Autor: Andreas Metzler
Data:  
Dla: exim-users
Temat: Re: [exim] ClamAV changes needing testing
Phil Pennock <exim-users@???> wrote:
> There's an upcoming change to ClamAV, to remove the scanning API which
> released versions of Exim use. I don't know the current schedule for
> that, but when we last checked, on bug 926, it was set for the middle of
> 2010. *cough*


> I've committed to CVS my patches to switch Exim to the new scanning API
> and clean up some of that code. This code could *really* do with some
> enthusiastic stress-testing by volunteers.

[...]
> If anyone feels like grabbing the code from HEAD in CVS and giving it a
> whirl and reporting back success after 1 day and 1 week (or failure if
> comes sooner), I'd appreciate it. Thanks.

[...]

Hello,

I have built a binary of today's CVS HEAD and will run it. It survives
a quick test (test mail gos through, eicar is rejected).

A couple of thoughts after building it:

CVS HEAD does not build if
WITH_CONTENT_SCAN=yes
is not set:

exim.c:3639: error: 'malware_name' undeclared (first use in this function)
exim.c:3639: error: (Each undeclared identifier is reported only once
exim.c:3639: error: for each function it appears in.)

QnD patch:
----------------------------------------
--- exim4-4.72+git20100606.orig/src/exim.c
+++ exim4-4.72+git20100606/src/exim.c
@@ -3624,6 +3624,7 @@ else setgid(exim_gid);
 if (malware_test_file)
   {
   int result;
+#ifdef WITH_CONTENT_SCAN
   set_process_info("scanning file for malware");
   result = malware_in_file(malware_test_file);
   if (result == FAIL)
@@ -3641,6 +3642,10 @@ if (malware_test_file)
   else
     printf("Malware scan detected malware of unknown name.\n");
   exit(EXIT_FAILURE);
+#else
+    printf("Malware scanning not enabled at compile time.\n");
+  exit(EXIT_FAILURE);
+#endif
   }


/* Handle a request to list the delivery queue */
----------------------------------------

There is a new ugly warning with WITH_CONTENT_SCAN=yes
exim.c:3629: warning: implicit declaration of function 'malware_in_file'

cu andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'