Re: [exim-dev] Towards 4.71

Αρχική Σελίδα
Delete this message
Reply to this message
Συντάκτης: Richard.Hall
Ημερομηνία:  
Προς: Tom Kistner
Υ/ο: exim-dev, Nigel Metheringham
Αντικείμενο: Re: [exim-dev] Towards 4.71
Apologies for the somewhat haphazard nature of this message, and even more
apologies if I'm mis-remembering something. I just wanted to "head 'em off
at the pass" before Nigel builds 4.71 ...

On Mon, 23 Nov 2009, Tom Kistner wrote:

> Nigel Metheringham wrote:
>
> > So is anything outstanding for 4.71?
>
> As of this morning, from my side: We're good to go.
>
> /tom


and slightly earlier on Mon, 23 Nov 2009, Tom Kistner wrote:
>
> Date: Mon, 23 Nov 2009 08:34:06 +0000
> From: Tom Kistner <tom@???>
> Reply-To: exim-dev@???
> To: exim-cvs@???
> Subject: [exim-cvs] cvs commit: exim/exim-src/src/pdkim pdkim.c
>
> tom         2009/11/23 08:34:05 GMT

>
>   Modified files:
>     exim-src/src/pdkim   pdkim.c
>   Log:
>   DKIM: fix wrong "pass" result on bodyhash mismatch

>
>   Revision  Changes    Path
>   1.10      +37 -12    exim/exim-src/src/pdkim/pdkim.c

[...]
>    /* Print debugging functions */
>    #ifdef PDKIM_DEBUG
>   @@ -1283,7 +1304,7 @@
>        #ifdef PDKIM_DEBUG
>        if (ctx->debug_stream)
>          fprintf(ctx->debug_stream,
>   -        "PDKIM
> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<\n");
>   +        "\nPDKIM
> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<\n");
>        #endif
>      }

[...]

I may be completely wrong, but ISTR there was a recent fix which _removed_
that additional newline, so this looks to me like a regression. Right now
I don't have the time or the wherewithal to go hunting for it, I'm afraid.
I did find a message from Andreas Metzler reporting it, at
http://lists.exim.org/lurker/message/20091114.160115.b4d8e58b.en.html

Sorry I can't be more specific, but better safe than sorry. (I hope;
otherwise it is egg-on-face time)

HTH,
Richard