------- You are receiving this mail because: -------
You are the QA contact for the bug.
http://bugs.exim.org/show_bug.cgi?id=486
--- Comment #7 from Simon Arlott <bugzilla.exim.simon@???> 2009-10-06 12:45:20 ---
I thought I had replied to this, but I can't find anything in my Sent folder...
(In reply to comment #6)
> So it does sorry. Got confused up the top with the expand.c only returning one
> of the types rathar than both. Completely missed the 2 different types with
> different length towards the end. Still, does the variable expansion section
> need to be expanded to include the new %M type return? currently the
> $tod_logfile variable returns the yyyymmdd version, perhaps
> $tod_logfile_monthly should return yyyymm to match.
There's no reason to add another variable when the existing one can be
truncated. The definition of $tod_logfile already explicitly refers to yyyymmdd
and %D, so no change is required.
> >Log file name management is not something that should be in logrotated. It's
> >flawed because it requires moving files that could be actively in use.
> You can move/rename an open file without incident on most *nix.
Yes, but exim will still be writing to last month's file until signalled.
If full strftime is required (and no one has requested it) then a new
configuration option would be required as "%D" already isn't forward-compatible
with strftime, so adding "%M" makes no difference.
Could this patch be applied now?
--
Configure bugmail:
http://bugs.exim.org/userprefs.cgi?tab=email
