[pcre-dev] [Bug 826] New: CMakeLists.txt: wrong usage of CMA…

Kezdőlap
Üzenet törlése
Szerző: Steven Van Ingelgem
Dátum:  
Címzett: pcre-dev
Tárgy: [pcre-dev] [Bug 826] New: CMakeLists.txt: wrong usage of CMAKE_SOURCE_DIR
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=826
           Summary: CMakeLists.txt: wrong usage of CMAKE_SOURCE_DIR
           Product: PCRE
           Version: 7.8
          Platform: x86
        OS/Version: Windows
            Status: NEW
          Severity: bug
          Priority: medium
         Component: Code
        AssignedTo: ph10@???
        ReportedBy: steven@???
                CC: pcre-dev@???



Created an attachment (id=305)
--> (http://bugs.exim.org/attachment.cgi?id=305)
CMakeLists.txt patch

Hi,


In CMakeLists.txt, there is "CMAKE_SOURCE_DIR" and "CMAKE_BINARY_DIR" used.
This is correct as long as you stay within this project.
But, if you include PCRE into your own project, it won't work anymore as the
directories point wrongly.

An example to clarify:
CMAKE_SOURCE_DIR: C:/__SVN__/own
CMAKE_BINARY_DIR: C:/__SVN__/own/build
PROJECT_SOURCE_DIR: C:/__SVN__/own/externals/pcre
PROJECT_BINARY_DIR: C:/__SVN__/own/build/externals/pcre

As you can see from the examples, I put PCRE into the externals/pcre directory.
Plus I am creating my build files (in this case MSVC2005) inside the build
directory.

Changing all occurrences of CMAKE_* -> PROJECT_* made the project build nicely.

Attached you will find the needed changes. This doesn't change anything to the
behaviour the CMakelists had before.


Greetings,
Steven


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email