[exim-dev] [Bug 721] [PATCH] open libspf dynamicaly

Top Page
Delete this message
Reply to this message
Author: Magnus Holmgren
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 721] [PATCH] open libspf dynamicaly
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=721




--- Comment #1 from Magnus Holmgren <holmgren@???> 2008-06-14 20:37:19 ---
I believe you should call log_write with LOG_PANIC_DIE if you need to bomb out.

i wonder if dynamic.c is as generic as it sounds. I.e. perhaps the
load_so/load_sym helpers should be in there and the libspf stubs in a separate
file that you cause to be compiled by editing EDITME (no #ifdef
DYNAMIC_LOADER). -DDYNAMIC_LOADER isn't specific to libspf as it is now
(although it's the only thing managed that way to start with.

I wonder if you gain much with that dltable[]. You can't put the stubs in a
table anyway, sou you could as well use separate variables. You could define a
macro that avoids duplicating all the if (! fn_foo_sym) fn_foo_sym =
load_sym(...).

I think that assuming that the dlname is libspf2.so.2 is more portable than
assuming that the .la file is in /usr/local/lib. You don't want to have to ask
Marc to patch your patch, do you? :-) If/when the ABI changes, the API might
change as well so that you'll have to adapt the code anyway.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email