Re: [pcre-dev] 7.6-RC2

Etusivu
Poista viesti
Lähettäjä: Sheri
Päiväys:  
Vastaanottaja: pcre-dev
Aihe: Re: [pcre-dev] 7.6-RC2
In ChangeLog:

> 6. Applied Sheri's patch to CMakeLists.txt to add
> NON_STANDARD_LIB_PREFIX and
> NON_STANDARD_LIB_SUFFIX and correct the comment about stack recursion.
>

I suggest to change number ChangeLog number 6 from:

"to add NON_STANDARD_LIB_PREFIX and NON_STANDARD_LIB_SUFFIX "

to

"to add NON_STANDARD_LIB_PREFIX and NON_STANDARD_LIB_SUFFIX
for dlls names built with mingw when configured with CMake."


I also think number 4 should be changed; it says it "makes it easy to
created [sic] a dll under mingw" but in fact it only supports making a
pcre.dll that doesn't work with any of the other Configure/Make
distribution targets.

So, I would change number 4 to say:

4.  A user submitted a patch to Makefile that makes it easy to create
     "pcre.dll" under mingw when using Configure/Make.  I added stuff to
     Makefile.am that cause it to include this special target, without
     affecting anything else. Note that the same mingw target plus all
     the other distribution libraries and programs are now supported
     when configuring with CMake (see number 6) instead of with
     Configure/Make.


Regards,
Sheri