Re: [pcre-dev] PCRE 7.5-RC2 Release candidate

Top Page
Delete this message
Author: Sheri
Date:  
To: pcre-dev
Subject: Re: [pcre-dev] PCRE 7.5-RC2 Release candidate
Philip Hazel wrote:
> Possibly in that environment, the directory scanning code does not get
> build. It is conditional on HAVE_WINDOWS_H and it uses windows.h.
>

Indeed HAVE_WINDOWS_H is not currently being defined or checked for when
configuring with cmake. I tried changing CMakeLists.txt and
config.h.generic myself and I managed to get it checked for (yes, logs
show cmake detects it when configuring for Visual Studio 2005) but I
never managed to get it working correctly at build time. At the moment I
get this error when building:

pcregrep.c(341) : fatal error C1017: invalid integer constant expression

Before trying to do those changes, I took the previously created Visual
Studio solution file and added a directive for HAVE_WINDOWS_H and built
it that way. The resulting pcregrep.exe still doesn't like file globs,
but it will recurse on ".", ".." or a specific directory name.

Unfortunately, the pattern for --include=pattern is not testing against
the entire file name. So it doesn't match ".+\.txt" for txt files in
subdirectories. It is testing against the file names at the specified
dir level only.

so
with the current directory "." at thisdir
and a file with matches at thisdir\sub1\sub2\thisfile.txt

it IS found if (no --include is specified) or with (--include="sub1")
but not found if (--include=".+\.txt")

(similar behavior with the one built in Msys, except at least file name
"*.txt" works (but doesn't recurse deeper).


>
>> I'd love to see it work properly; would be happy to relay any
>> intermediate type results you'd need to see to fix it if and when you
>> ever feel like tackling it.
>>
>
> The problem is that I wouldn't know where to start. However, all is not
> lost. I had a private message from Bob Rossi, who is away and not able
> to post to the mailing list. He offered to take a look at all this
> Windows stuff when he is back in his normal environment. Meanwhile, I
> plan to release 7.5 sometime next week unless something important turns
> up to cause me to hold on.
>
>

Asked you before about the cpp unittest failure. Is failing for me with
both the Visual Studio version and the mys version.

>pcrecpp_unittest

Testing FullMatch
pcrecpp_unittest.cc:865: Check failed:
RE("(.*)").FullMatch("1234567890123456", (long long*)NULL)

Regards,
Sheri