[exim-dev] [Bug 428] Greatly expand ratelimit features

Góra strony
Delete this message
Reply to this message
Autor: Dave Lugo
Data:  
Dla: exim-dev
Temat: [exim-dev] [Bug 428] Greatly expand ratelimit features
------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=428




--- Comment #13 from Dave Lugo <dlugo@???> 2007-07-29 22:26:04 ---
Another followup...

I changed 0.0 to 1.0 in this (~line 2275 in acl.c):

if (dbd == NULL)
{
HDEBUG(D_acl) debug_printf("ratelimit initializing new key's data\n");
dbd = store_get(sizeof(dbdata_ratelimit));
dbd->time_stamp = tv.tv_sec;
dbd->time_usec = tv.tv_usec;
dbd->rate = 1.0;
^^^^^^^^^^^^^^
}


... which works nicely to add a new record with a count of '1'.

Problem is, when I do this to see if a WL entry should fire:

         ratelimit   = 1.0 / 52w / per_cmd / strict / noupdate /
${lc:$local_part}@${lc:$domain}:${lc:$sender_address}


... it always returns true, even for stuff that isn't in the ratelimit db.

I guess that ratelimit uses the default 1.0 for adding a null record, even when
doing noupdate. Shouldn't ratelimit return 0 if 0.0 or null if the record
isn't found
*and* noupdate is being used?

(my apologies in advance if I'm confused)

Thanks,

Dave


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email