On Fri, 2007 Jul 20 11:41:35 -0700, Craig Silverstein wrote:
>
> } I just went with adding extra #include directives to the appropriate
> } .cc files.
>
> Why can't we just do the same PCRECPP_EXP_DEFN rigamarole in
> pcre_stringpiece.h that we do in pcre_cpp.h? Perhaps you'll have to
> change the outer #ifdef guard with
>
> #if defined(_WIN32) && !defined(PCRECPP_EXP_DECL)
PCRECPP_EXP_DEFN should not be defined in more than one place, as that is
generally bad practice.
My first guess would be to have pcre_stringpiece.h #include pcrecpp.h. But
if the former should be able to stand on its own without the RE class et
al. floating about, how about breaking out the PCRECPP_EXP_DEFN definitions
into a separate "private" header file, to be referenced only by the pcrecpp
headers themselves?
--Daniel
--
NAME = Daniel Richard G. ## Remember, skunks _\|/_ meef?
EMAIL1 = skunk@??? ## don't smell bad--- (/o|o\) /
EMAIL2 = skunk@??? ## it's the people who < (^),>
WWW = http://www.******.org/ ## annoy them that do! / \
--
(****** = site not yet online)
