Re: [exim-dev] [PATCH] fix deprecated SPF-Received header

Etusivu
Poista viesti
Vastaa
Lähettäjä: Robert Millan
Päiväys:  
Vastaanottaja: exim-dev
Aihe: Re: [exim-dev] [PATCH] fix deprecated SPF-Received header

Oops. I didn't remember that there's a bug tracker.

Filed as: http://www.exim.org/bugzilla/show_bug.cgi?id=519

On Sun, Jun 24, 2007 at 11:50:21PM +0200, Robert Millan wrote:
>
> Hi,
>
> A pair of parts in the source / docs refer to SPF-Received header, but this
> header is no longer in use since RFC 4408 superceds it in favour of
> Received-SPF.
>
> I assume SPF-Received was used in libspf2 in the pre-RFC stage, but this is
> no longer the case (I checked with current code).
>
> See attached patch.
>
> --
> Robert Millan
>
> My spam trap is honeypot@???. Note: this address is only intended
> for spam harvesters. Writing to it will get you added to my black list.


> diff -ur exim-4.67.old/doc/experimental-spec.txt exim-4.67/doc/experimental-spec.txt
> --- exim-4.67.old/doc/experimental-spec.txt    2007-04-17 15:06:40.000000000 +0200
> +++ exim-4.67/doc/experimental-spec.txt    2007-06-24 23:46:03.000000000 +0200
> @@ -642,7 +642,7 @@
>    it for logging purposes.

>
>    $spf_received
> -  This contains a complete SPF-Received: header that can be
> +  This contains a complete Received-SPF: header that can be
>    added to the message. Please note that according to the SPF
>    draft, this header must be added at the top of the header
>    list. Please see section 10 on how you can do this.
> diff -ur exim-4.67.old/src/globals.h exim-4.67/src/globals.h
> --- exim-4.67.old/src/globals.h    2007-04-17 15:06:39.000000000 +0200
> +++ exim-4.67/src/globals.h    2007-06-24 23:46:08.000000000 +0200
> @@ -687,7 +687,7 @@
>  #endif
>  #ifdef EXPERIMENTAL_SPF
>  extern uschar *spf_header_comment;     /* spf header comment */
> -extern uschar *spf_received;           /* SPF-Received: header */
> +extern uschar *spf_received;           /* Received-SPF: header */
>  extern uschar *spf_result;             /* spf result in string form */
>  extern uschar *spf_smtp_comment;       /* spf comment to include in SMTP reply */
>  #endif


> --
> ## List details at http://www.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##



--
Robert Millan

My spam trap is honeypot@???. Note: this address is only intended
for spam harvesters. Writing to it will get you added to my black list.