[exim-dev] [Bug 428] Greatly expand ratelimit features

Top Page
Delete this message
Reply to this message
Author: bug428
Date:  
To: exim-dev
Old-Topics: [exim-dev] [Bug 428] New: Greatly expand ratelimit features
Subject: [exim-dev] [Bug 428] Greatly expand ratelimit features
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

http://www.exim.org/bugzilla/show_bug.cgi?id=428


ph10@??? changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED





------- Comment #9 from ph10@??? 2007-06-20 15:19 -------
(In reply to comment #8)
> Please note Bug #496 - spaces in the key cause exim_tidydb not to
> process the ratelimit DB properly.


My new keys don't have spaces (though I guess the user's bit might have.)

> I don't believe that "forgetting" the ratelimit DB on an upgrade will
> matter greatly, either *unless* people start to use it for greylisting
> in which case the docs will have to caveat/note the changes greatly.


Good. I've committed my version of the patch (and done some simple tests). I'll
also upload the patch here. One issue: the code keeps the rate in main memory
for re-use in the same process. It was always updating this copy; I've made it
not do so for /noupdate. But it still does it even when it doesn't update the
database because it's leaky. I wonder if it should only update the in-memory
copy when it updates the database?

--
Configure bugmail: http://www.exim.org/bugzilla/userprefs.cgi?tab=email