[exim-cvs] cvs commit: exim/exim-doc/doc-txt ChangeLog exim…

Top Page
Delete this message
Reply to this message
Author: Philip Hazel
Date:  
To: exim-cvs
Subject: [exim-cvs] cvs commit: exim/exim-doc/doc-txt ChangeLog exim/exim-src/src/lookups oracle.c
ph10 2007/03/13 09:59:07 GMT

  Modified files:
    exim-doc/doc-txt     ChangeLog 
    exim-src/src/lookups oracle.c 
  Log:
  Change HDA_SIZE in oracle.c from 256 to 512. This is needed for 64-bit
  cpus.


  Revision  Changes    Path
  1.489     +3 -0      exim/exim-doc/doc-txt/ChangeLog
  1.5       +7 -2      exim/exim-src/src/lookups/oracle.c


  Index: ChangeLog
  ===================================================================
  RCS file: /home/cvs/exim/exim-doc/doc-txt/ChangeLog,v
  retrieving revision 1.488
  retrieving revision 1.489
  diff -u -r1.488 -r1.489
  --- ChangeLog    13 Mar 2007 09:50:22 -0000    1.488
  +++ ChangeLog    13 Mar 2007 09:59:07 -0000    1.489
  @@ -1,4 +1,4 @@
  -$Cambridge: exim/exim-doc/doc-txt/ChangeLog,v 1.488 2007/03/13 09:50:22 ph10 Exp $
  +$Cambridge: exim/exim-doc/doc-txt/ChangeLog,v 1.489 2007/03/13 09:59:07 ph10 Exp $


   Change log file for Exim from version 4.21
   -------------------------------------------
  @@ -148,6 +148,9 @@
         was a macro that became an assignment, so it seemed to work. This has
         changed to a proper function call with a void return, hence the compile
         error. Exim's code has been fixed.
  +
  +PH/34 Change HDA_SIZE in oracle.c from 256 to 512. This is needed for 64-bit
  +      cpus.



Exim version 4.66

  Index: oracle.c
  ===================================================================
  RCS file: /home/cvs/exim/exim-src/src/lookups/oracle.c,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- oracle.c    8 Jan 2007 10:50:19 -0000    1.4
  +++ oracle.c    13 Mar 2007 09:59:07 -0000    1.5
  @@ -1,4 +1,4 @@
  -/* $Cambridge: exim/exim-src/src/lookups/oracle.c,v 1.4 2007/01/08 10:50:19 ph10 Exp $ */
  +/* $Cambridge: exim/exim-src/src/lookups/oracle.c,v 1.5 2007/03/13 09:59:07 ph10 Exp $ */


   /*************************************************
   *     Exim - an Internet mail transport agent    *
  @@ -42,9 +42,14 @@
   #define MAX_SELECT_LIST_SIZE    32     /* maximum number of columns (not rows!) */


/* Paul's comment on this was "change this to 512 for 64bit cpu", but I don't
-understand why. The Oracle manual just asks for 256 bytes. */
+understand why. The Oracle manual just asks for 256 bytes.

-#define HDA_SIZE 256
+That was years ago. Jin Choi suggested (March 2007) that this change should
+be made in the source, as at worst it wastes 256 bytes, and it saves people
+having to discover about this for themselves as more and more systems are
+64-bit. So I have changed 256 to 512. */
+
+#define HDA_SIZE 512

/* Internal/external datatype codes */