[pcre-dev] PCRE autotools patch drg2

Startseite
Nachricht löschen
Autor: Daniel Richard G.
Datum:  
To: pcre-dev
Betreff: [pcre-dev] PCRE autotools patch drg2
Okay everyone, new version of my patch. This one integrates Bob's changes
between patch 5 and 6, plus a few more of my own. It is not quite yet patch
7, but please give it a whirl, and let me know what more it needs.

To apply:

    cd /path/to/pcre-7.0
    mv ucptable.c ucptable.h
    mv perltest perltest.pl
    patch -p1 </path/to/pcre-7.0-drg2.patch
    chmod +x autogen.sh
    ./autogen.sh
    ./configure
    make distcheck



Change notes from drg1:


==== configure.ac ====

* Forgot to mention previously: I've changed the date format from
18-Dec-2006 to 2006-Dec-18---any objections? (I believe Philip said he
was OK with it, as long as there was no date ambiguity.)

The idea here is to follow the example of ISO 8601, which is emerging as
a better-than-either compromise between the long-dueling U.S.
(MM-DD-YYYY) and European (DD-MM-YYYY) date formats.

* Fixed the --disable-cpp not-working problem (along with a few other
options that were affected).

* Changed --disable-stack-for-recursion to --enable-stack-for-recursion, as
this is "no" by default.

* Went out on a limb here: I've replaced the various
--enable-newline-is-foo options with a single --enable-newline=NL, where
NL can be "lf", "cr", "crlf", or "any". I can add back in the -is-foo
options if need be; do we need to keep the options the same?

* Added checking of --with-link-size option argument.

* There's a simplification I'd like to make: When you give
AC_ARG_ENABLE(foo, ...), Autoconf automatically defines for you a shell
variable $enable_foo that contains the value of the option ("yes", "no",
or whatever was specified with --enable-foo=blah). Same deal with
AC_ARG_WITH and $with_foo.

What do y'all say we ditch the ac_pcre_* variables, and use
enable_foo/with_foo in their stead? We could then eliminate the third
argument from most of the AC_ARG_ENABLE/WITH calls, as it would be
redundant.

==== Makefile.am ====

* perltest --> perltest.pl

* Fixed up the pcrecpp documentation conditionals. For future reference:
there is no such thing as dist_noinst_MANS; you have to assign those
files to EXTRA_DIST.

==== pcre_compile.c ====

* Use "#ifndef EBCDIC" instead of "#if !EBCDIC", to fix the "EBCDIC not
defined" problem that Philip observed.


--Daniel


-- 
NAME   = Daniel Richard G.       ##  Remember, skunks       _\|/_  meef?
EMAIL1 = skunk@???        ##  don't smell bad---    (/o|o\) /
EMAIL2 = skunk@???      ##  it's the people who   < (^),>
WWW    = http://www.******.org/  ##  annoy them that do!    /   \
--
(****** = site not yet online)