------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://www.exim.org/bugzilla/show_bug.cgi?id=248
ph10@??? changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Comment #5 from ph10@??? 2007-01-30 15:16 -------
(In reply to comment #3)
> Preliminary solution adding new variables, setting those in smtp_connect(), and
> deferring helo_data expansion
I have committed this patch - modified to fix two bugs (just to prove I do read
patches before applying them. :-) (1) By moving the code in verify.c, you lost
the values of $domain during the expansion of helo_data. (2) More importantly,
by putting the expansion after connect() in smtp.c, you lost the value of
helo_data completely when delivering a second message down the same SMTP
connection, and this caused a problem when TLS was in use, when another EHLO
takes place. The tests run OK with my fixes, and I've added a few more tests
too.
> The variables should be reset when closing
> the connection. To maintain abstraction, we then need a new smtp_close()
> function that does that and is called in place of close(2).
I haven't done this; typically after close() Exim will either end the process,
or make another connection, so I wasn't sure that it was worth it.
--
Configure bugmail:
http://www.exim.org/bugzilla/userprefs.cgi?tab=email
