Johannes Berg wrote:
> On Mon, 2006-09-25 at 13:08 +0200, Nico Erfurth wrote:
>> + case 'a':
>> + if (Ustrncmp(big_buffer, "-acl ", 5) == 0)
>
>> + else if (Ustrncmp(big_buffer, "-aclc ", 6) == 0 ||
>> + Ustrncmp(big_buffer, "-aclm ", 6) == 0)
>
> Wouldn't it make sense to switch those two around saving another string
> comparison in the common case that only new variables are present, and
> possibly even moving the "-acl " part all the way to the end? As-is,
> that'll always be executed but never result in a match (on new-style acl
> spool files).
Switching both around would be a good idea. As may be reordering the
compares by "most commonly used".
Nico
