Re: [exim-dev] current snapshot (was: patch for named acl va…

Top Page
Delete this message
Reply to this message
Author: Nico Erfurth
Date:  
To: exim-dev
Subject: Re: [exim-dev] current snapshot (was: patch for named acl variables)
Jakob Hirsch wrote:

> uh, no, forget this, mbox_file would not be closed then. You could add
> mbox_file = NULL after the fclose in your patch. Or something else, I
> think you'll figure it out yourself. :)


Yes, you're right. :)
Never post a patch until you tested it yourself, even if it's such a
small change. :)

Nico

--- spool_mbox.c.buggy  2006-09-21 17:55:42.000000000 +0200
+++ spool_mbox.c        2006-09-21 19:02:59.000000000 +0200
@@ -139,6 +139,8 @@
          };
        };
      } while (j > 0);
+    (void)fclose(mbox_file);
+    mbox_file = NULL;


      Ustrcpy(spooled_message_id, message_id);
      spool_mbox_ok = 1;