Re: [exim-dev] RFC: Refactoring expand_string_internal

Top Pagina
Delete this message
Reply to this message
Auteur: Philip Hazel
Datum:  
Aan: Nico Erfurth
CC: exim-dev
Onderwerp: Re: [exim-dev] RFC: Refactoring expand_string_internal
On Tue, 8 Aug 2006, Nico Erfurth wrote:

> > You'd lose some performance, of course, but how much that would affect
> > the overall performance of Exim I would not like to guess.
>
> I don't think so, because it wouldn't differ very much from the way gcc
> handles the switch/case statement. Also it would give the opportunity to
> look at some code again and maybe tweak it a little bit.


Function calls lose performance, but your second point is valid.

> I'm just not a fan of such big functions, because you loose a lot of
> readability (IMHO).


I know that I tend to write big functions instead of breaking them down,
but then my code tends to run fast. I feel there is some connection
between these facts.


-- 
Philip Hazel            University of Cambridge Computing Service
Get the Exim 4 book:    http://www.uit.co.uk/exim-book