On Tue, 8 Aug 2006, Nico Erfurth wrote:
> I just looked through expand.c and saw that expand_string_internal grew
> a lot over the last 2 years. Currently it's 2359 lines long, expand.c is
> 5442 lines in total .... ;)
Yes, well, people keep on adding things. :-)
> What do others think about refactoring it a bit? Some larger chunks
> could be placed in subroutines, maybe all functionality should be
> factored out into single subroutines, called via a mapping-tables
> indexed by the expansion-type.
You'd lose some performance, of course, but how much that would affect
the overall performance of Exim I would not like to guess.
--
Philip Hazel University of Cambridge Computing Service
Get the Exim 4 book: http://www.uit.co.uk/exim-book
