fanf2 2005/09/19 19:00:47 BST
Modified files:
exim-doc/doc-txt ChangeLog
exim-src/src/routers dnslookup.c
Log:
Exim produced the error message "an SRV record indicated no SMTP
service" if it encountered an MX record with an empty target hostname.
The message is now "an MX or SRV record indicated no SMTP service".
Revision Changes Path
1.238 +4 -0 exim/exim-doc/doc-txt/ChangeLog
1.8 +4 -4 exim/exim-src/src/routers/dnslookup.c
Index: ChangeLog
===================================================================
RCS file: /home/cvs/exim/exim-doc/doc-txt/ChangeLog,v
retrieving revision 1.237
retrieving revision 1.238
diff -u -u -r1.237 -r1.238
--- ChangeLog 19 Sep 2005 14:01:51 -0000 1.237
+++ ChangeLog 19 Sep 2005 18:00:47 -0000 1.238
@@ -1,4 +1,4 @@
-$Cambridge: exim/exim-doc/doc-txt/ChangeLog,v 1.237 2005/09/19 14:01:51 ph10 Exp $
+$Cambridge: exim/exim-doc/doc-txt/ChangeLog,v 1.238 2005/09/19 18:00:47 fanf2 Exp $
Change log file for Exim from version 4.21
-------------------------------------------
@@ -211,6 +211,10 @@
type ("H").
PH/50 Make never_users, trusted_users, admin_groups, trusted_groups expandable.
+
+TF/07 Exim produced the error message "an SRV record indicated no SMTP
+ service" if it encountered an MX record with an empty target hostname.
+ The message is now "an MX or SRV record indicated no SMTP service".
Exim version 4.52
Index: dnslookup.c
===================================================================
RCS file: /home/cvs/exim/exim-src/src/routers/dnslookup.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -u -r1.7 -r1.8
--- dnslookup.c 19 Sep 2005 09:41:37 -0000 1.7
+++ dnslookup.c 19 Sep 2005 18:00:47 -0000 1.8
@@ -1,4 +1,4 @@
-/* $Cambridge: exim/exim-src/src/routers/dnslookup.c,v 1.7 2005/09/19 09:41:37 fanf2 Exp $ */
+/* $Cambridge: exim/exim-src/src/routers/dnslookup.c,v 1.8 2005/09/19 18:00:47 fanf2 Exp $ */
/*************************************************
* Exim - an Internet mail transport agent *
@@ -304,9 +304,9 @@
if (rc != HOST_FIND_FAILED) break;
- /* Check to see if the failure is the result of MX records pointing
- to non-existent domains, and if so, set an appropriate error message; the
- case of an SRV record pointing to "." is another special case that we can
+ /* Check to see if the failure is the result of MX records pointing to
+ non-existent domains, and if so, set an appropriate error message; the case
+ of an MX or SRV record pointing to "." is another special case that we can
detect. Otherwise "unknown mail domain" is used, which is confusing. Also, in
this case don't do the widening. We need check only the first host to see if
its MX has been filled in, but there is no address, because if there were any
@@ -319,7 +319,7 @@
{
setflag(addr, af_pass_message); /* This is not a security risk */
if (h.name[0] == 0)
- addr->message = US"an SRV record indicated no SMTP service";
+ addr->message = US"an MX or SRV record indicated no SMTP service";
else
{
addr->message = US"all relevant MX records point to non-existent hosts";
