Hello,
while hacking in Exim, I noticed that string_cat lacked a const
on the 4th parameter. Are there particular reasons why const
is not used there? I would appreciate applying the patch below.
Michael
----------------------------------------------------------------------
--- functions.h.orig 2003-04-01 14:34:39.000000000 +0200
+++ functions.h 2003-04-01 14:35:03.000000000 +0200
@@ -237,7 +237,7 @@
extern int stdin_ferror(void);
extern int stdin_ungetc(int);
extern uschar *string_base62(unsigned long int);
-extern uschar *string_cat(uschar *, int *, int *, uschar *, int);
+extern uschar *string_cat(uschar *, int *, int *, const uschar *, int);
extern uschar *string_copy_dnsdomain(uschar *);
extern uschar *string_copy_malloc(uschar *);
extern uschar *string_copylc(uschar *);
--- string.c.orig 2003-04-01 14:34:29.000000000 +0200
+++ string.c 2003-04-01 14:34:52.000000000 +0200
@@ -785,7 +785,7 @@
*/
uschar *
-string_cat(uschar *string, int *size, int *ptr, uschar *s, int len)
+string_cat(uschar *string, int *size, int *ptr, const uschar *s, int len)
{
int p = *ptr;
