Re: [Exim] local_scan api version proposal

Etusivu
Poista viesti
Vastaa
Lähettäjä: Marc MERLIN
Päiväys:  
Vastaanottaja: Nico Erfurth, Philip Hazel, Exim-users
Aihe: Re: [Exim] local_scan api version proposal
On Sun, Mar 23, 2003 at 03:49:22PM -0800, Marc MERLIN wrote:
> --
> On Sun, Mar 16, 2003 at 10:03:49AM +0100, Nico Erfurth wrote:
> > #define LOCAL_SCAN_ABI_VERSION_MAJOR 1
> > #define LOCAL_SCAN_ABI_VERSION_MINOR 0
> > #define LOCAL_SCAN_ABI_VERSION \
> > LOCAL_SCAN_ABI_VERSION_MAJOR.LOCAL_SCAN_ABI_VERSION_MINOR
> >
> > This allows easy compiletime-checking to make a patch work with different
> > ABIs.
>
> Philip, here's a new version of the patch.
> The only portion that would really help us if you included it is:
> --- exim-4.14-0/src/local_scan.h    Tue Mar 11 04:20:20 2003
> +++ exim-4.14-1/src/local_scan.h    Sun Mar 23 15:34:57 2003
> @@ -71,6 +71,15 @@

>
> #define SPOOL_DATA_START_OFFSET (MESSAGE_ID_LENGTH+3)
>
> +/* local_scan() ABI version number for dynamic libraries
> + The major number is increased when the ABI is changed in a non
> + backward compatible way.
> + The minor number is increased each time a new feature is added (in a
> + way that doesn't break backward compatibility) -- Marc */
> +#define LOCAL_SCAN_ABI_VERSION_MAJOR 1
> +#define LOCAL_SCAN_ABI_VERSION_MINOR 0
> +#define LOCAL_SCAN_ABI_VERSION \
> + LOCAL_SCAN_ABI_VERSION_MAJOR.LOCAL_SCAN_ABI_VERSION_MINOR
>
> /* Structure definitions that are documented as visible in the function. */
>


Mmmh, let's just forget about
> +#define LOCAL_SCAN_ABI_VERSION \
> + LOCAL_SCAN_ABI_VERSION_MAJOR.LOCAL_SCAN_ABI_VERSION_MINOR


1) This changes from an int to a float (incompatible with old usage)
2) The above macro, given to me on this list, doesn't actually compile (Duh)
3) I really don't need LOCAL_SCAN_ABI_VERSION anyway.

> +#define LOCAL_SCAN_ABI_VERSION_MAJOR 1
> +#define LOCAL_SCAN_ABI_VERSION_MINOR 0


should do it.

Thanks
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems & security ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/   |   Finger marc_f@??? for PGP key