[exim-dev] [Bug 2392] exigrep: Option processing is case-ins…

Top Page
Delete this message
Reply to this message
Author: admin
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 2392] exigrep: Option processing is case-insensitive
https://bugs.exim.org/show_bug.cgi?id=2392

Git Commit <git@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |git@???


--- Comment #8 from Git Commit <git@???> ---
Git commit:
https://git.exim.org/exim.git/commitdiff/82a996b1cc5a4299674260962778fc2ad1f2f75e

commit 82a996b1cc5a4299674260962778fc2ad1f2f75e
Author:     Heiko Schlittermann (HS12-RIPE) <hs@???>
AuthorDate: Wed Apr 17 23:33:03 2019 +0200
Commit:     Heiko Schlittermann (HS12-RIPE) <hs@???>
CommitDate: Fri Apr 19 15:48:50 2019 +0200


    exigrep: do case sensitive option processing again. Closes 2392


    -M (--related) was hidden by -m (--man), because of case insensitive
    option matching. (4.90 ⦠4.92 did case insensitive option processing)


    Thanks to Andreas Metzler for reporting this issue.
---
 doc/doc-txt/ChangeLog | 7 +++++++
 src/src/exigrep.src   | 4 ++--
 2 files changed, 9 insertions(+), 2 deletions(-)


diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index 01ee179..cf8c41a 100644
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -70,6 +70,13 @@ HS/01 Bug 2390: Use message_id for tempfile creation to
avoid races in a
       systems which restrict the file name length to lower values.
       (It was "hdr.$pid".)


+HS/01 Bug 2390: Use message_id for tempfile creation to avoid races in a
+      shared (NFS) environment.
+
+HS/02 Bug 2392: exigrep does case sensitive *option* processing (as it
+      did for all versions <4.90). Notably -M, -m, --invert, -I may be
+      affected.
+


Exim version 4.92
-----------------
diff --git a/src/src/exigrep.src b/src/src/exigrep.src
index 5db01fe..afd3538 100644
--- a/src/src/exigrep.src
+++ b/src/src/exigrep.src
@@ -5,7 +5,7 @@ use strict;
BEGIN { pop @INC if $INC[-1] eq '.' };

use Pod::Usage;
-use Getopt::Long;
+use Getopt::Long qw(:config no_ignore_case);
use File::Basename;

# Copyright (c) 2007-2017 University of Cambridge.
@@ -354,7 +354,7 @@ Do not use a pager, even if STDOUT is connected to a
terminal.
=item B<-h>|B<--help>

Print a short reference help. For more detailed help try L<exigrep(8)>,
-or C<exigrep -m>.
+or C<exigrep --man>.

=item B<-m>|B<--man>

--
You are receiving this mail because:
You are on the CC list for the bug.