Re: [exim-dev] [Bug 2368] Exim 4.91-RC4 compile warning for …

Top Page
Delete this message
Reply to this message
Author: Andrew C Aitchison
Date:  
To: admin
CC: exim-dev
Subject: Re: [exim-dev] [Bug 2368] Exim 4.91-RC4 compile warning for unused result
On Sat, 2 Feb 2019, admin--- via Exim-dev wrote:

> https://bugs.exim.org/show_bug.cgi?id=2368
>
> Jeremy Harris <jgh146exb@???> changed:
>
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>         Resolution|---                         |WONTFIX
>           Assignee|nigel@???              |jgh146exb@???
>             Status|NEW                         |RESOLVED

>
> --- Comment #1 from Jeremy Harris <jgh146exb@???> ---
> This is a matter for choosing compiler switches to avoid doing such static
> analysis. We refuse to endlessly chase such things by using more-and-more
> convoluted coding. Even the cast-to-void could be regarded as such an
> attempt, but it least its heritage goes back over thirty years.


This patch makes the code clearer,
and makes it explicit that we know what we are doing.
If it makes that the compiler happy at the same time,
then we can leave the switches set in a way that helps us avoid writing
new bugs.

I agree that this is not the time to put this fix into the next release,
but we could have a general code cleanup bug depend in this for the
next code clean up.

-- 
Andrew C. Aitchison                    Cambridge, UK
             andrew@???